627881 - bad file path in toolkit/themes/gnomestripe/mozapps/jar.mn

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Pascal Chevrel:pascalc]

Attachment: patch for the typo

There is a typo in toolkit/themes/gnomestripe/mozapps/jar.mn that probably prevents applications to load this ressource:

kin/classic/mozapps/extensions/stripes-info-negative.png

should be:

skin/classic/mozapps/extensions/stripes-info-negative.png

attaching a patch (asking review to Dave Townsend since he seems to be one of the two people editing this file on a regular basis, feel free to reassign)

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 505964 [details] [diff] [review]
patch for the typo

You just deleted the line? Why not replace it with the correct one?

Comment 2

[Pascal Chevrel:pascalc]

That's what I did:

-+ kin/classic/mozapps/extensions/stripes-info-negative.png (extensions/stripes-info-negative.png)
++ skin/classic/mozapps/extensions/stripes-info-negative.png (extensions/stripes-info-negative.png)

Comment 3

[Pascal Chevrel:pascalc]

it looks like there is a bug in the way bugzilla displays patches, I guess it is confused by the fact that this manifest file has its lines starting with pluses, if you look at the raw source of the patch, you can see that the line is fixed, not deleted:

https://bug627881.bugzilla.mozilla.org/attachment.cgi?id=505964

Comment 4

[Pascal Chevrel:pascalc]

Comment on attachment 505964 [details] [diff] [review]
patch for the typo

see comment #3, re-requesting review. Thanks.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 505964 [details] [diff] [review]
patch for the typo

So it is, sorry about that.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/7864ae3b2a0e